This isn't used within the function at all in any implementations, so we
can remove it entirely.

patch_manager: Minor cleanup

We make it explicit that we're truncating arithmetic here to resolve
compiler warnings (even if the sizes weren't u32/u64 arithmetic
generally promotes to int :<)

We can use these to avoid typing the same type redundantly. This way, if
these ever change, only a single location needs to be modified.

These functions are only used within this translation unit, so we can
make them internally linked.

crypto/key_manager: Remove dependency on the global system accessor

We can supply the content provider as an argument instead of hardcoding
a global accessor in the implementation.

kernel: Remove all dependencies on the global system instance

With this, the kernel finally doesn't depend directly on the global
system instance anymore.

service: Remove two usages of the global system accessor

kernel/scheduler: Use std::mutex instead of spin lock

Remove bad and useless packages from LGTM build

cmake: Update to Qt 5.12.8

bsd: Resolve a few warnings

audio_core: Apollo Part 1, AudioRenderer refactor

It still fails due to CMake version being 3.13.4, but at
least we are not ones to blame now.

Project Mjölnir: Part 2 - Controller Applet

configure_input_player: Resolve sign conversion warnings in UpdateMappingWithDefaults()

video_core: Remove all Core::System references in renderer

gc_adapter: Make DeviceConnected() a const member function

Removes more instances of reliance on global state.

This doesn't modify instance state, so it can be made const.

Previously the address provided to SendToImpl would never be propagated
to SendTo(). This fixes that.

Same behavior, less typing.

We can simplify this a little by explicitly specifying the typename for
the lambda function.

game_list_p: Mark some constants as constexpr

Now that the GPU is initialized when video backends are initialized,
it's no longer needed to query components once the game is running: it
can be done when yuzu is booting.

This allows us to pass components between constructors and in the
process remove all Core::System references in the video backend.

 services: Implement most of bsd:s and GetCurrentIpAddress from nifm

hid: Implement MergeSingleJoyasDualJoy

- Used in multiple games such as Super Mario Odyssey.

Resolves -Wsign-compare and -Wunused-variable

- Some games like Shipped have a minimum requirement of 0 connected players and is undesired behavior. We must require a minimum of 1 player connected regardless of what games may ask.

Now left and right joycons have the same priority (meaning both needs to be supported by the game).

Explanation of the new heuristic:
Assign left joycons to even player indices and right joycons to odd player indices.
We do this since Captain Toad Treasure Tracker expects a left joycon for Player 1 and a right Joycon for Player 2 in 2 Player Assist mode.