The bug(s) happened because we swapped the contents on values.game_dirs, but the pointer each item had to their respective game_dir wasn't updated. This made it so that the item had the wrong game_dir associated with it after a "move up" or "move down" operation. It can be observed by choosing "open directory location" after such operation.

Changed from raw pointer to an index because it's equivalent but a bit clearer, but the change is not essential.

Co-Authored-By: Vitor K <29167336+vitor-k@users.noreply.github.com>

core: Silence Wclass-memaccess warnings and enforce it

video_core: Resolve -Wdocumentation warnings

vulkan_debug_callback: Add missing header guard

Silences some -Wdocumentation warnings on Clang.

Prevents inclusion issues from occurring.

input_interpreter: Mark two member functions as const

buffer_cache/buffer_base: Add a range tracking buffer container and tests

These aren't stateful functions, so we can make use of const.

While we're at, we can resolve some -Wdocumentation warnings.

input_interpreter: Add method to check for a button press state

This allows to check for continuous input for the duration of a button press/hold

X86/NativeClock: Improve performance of clock calculations on hot path.

common/tree: Convert defines over to templates

vulkan_memory_allocator: Improvements to the memory allocator

common/common_funcs: Rename INSERT_UNION_PADDING_{BYTES,WORDS} to _NOINIT

Treat -Wclass-memaccess as an error.

This requires making several types trivial and properly initialize
them whenever they are called.

INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.

Use the Download memory type where it matters.

Implements the allocator logic to handle download memory types. This
will try to use HOST_CACHED_BIT when available.

Allow users of the allocator to hint memory usage for downloads. This
removes the non-descriptive boolean passed for "host visible" or not
host visible memory commits, and uses an enum to hint device local,
upload and download usages.

Allow using the abstraction from the OpenGL backend.

"Memory manager" collides with the guest GPU memory manager, and a
memory allocator sounds closer to what the abstraction aims to be.

Fix a bug where the memory allocator could leave gaps between commits.
To fix this the allocation algorithm was reworked, although it's still
short in number of lines of code.

Rework the allocation API to self-contained movable objects instead of
naively using an unique_ptr to do the job for us. Remove the VK prefix.

common/timer: Remove

common/alignment: Rename AlignBits to AlignUpLog2 and use constraints

common/bit_util: Replace CLZ/CTZ operations with standardized ones

Makes for less code that we need to maintain.

AlignUpLog2 describes what the function does better than AlignBits.

This is a leftover from citra and dolphin that isn't used at all,
particularly given the <chrono> header exists.

common/color: Remove

cmake: Remove yuzu_tester

This is a leftover from Citra we no longer use.

{video_,}core/cmake: Remove Werror flags already defined code-base wide 

These flags are already defined in src/cmake.

cmake: Enforce -Wunused-function code-base wise

vulkan_common: Silence missing initializer warnings