These are only ever read from, so we don't need to make a copy of all
the keys here.

Given it's only used in one spot and has a fairly generic name, we can
just specify it directly in the function call. This also the benefit of
automatically moving it.

Commented out code shouldn't be left in without a reason indicating why
in a comment.

Instead, we can make it part of the type and make named variables for
them, so they only require one definition (and if they ever change for
whatever reason, they only need to be changed in one spot).

Given the VirtualFile instance isn't stored into the class as a data
member, or written to, this can just be turned into a const reference,
as the constructor doesn't need to make a copy of it.

Orders the members in the exact order they would be initialized. This
also prevents compiler warnings about this sort of thing.

Gets unused includes out of the headers and moves them into the cpp file
if they're used there instead.

If the data is unconditionally being appended to the back of a
std::vector, we can just directly insert it there without the need to
insert all of the elements one-by-one with a std::back_inserter.

If a conditional (or it's body) travels more than one line, it should be
braced.

Given the filesystem should always be assumed to be volatile, we should
check and bail out if a seek operation isn't successful. This'll prevent
potentially writing/returning garbage data from the function in rare
cases.

This also allows removing a check to see if an offset is within the
bounds of a file before perfoming a seek operation. If a seek is
attempted beyond the end of a file, it will fail, so this essentially
combines two checks into one in one place.

Given the file is opened a few lines above and no operations are done,
other than check if the file is in a valid state, the read/write pointer
will always be at the beginning of the file.

crypto: Add support for full key derivation

kernel/process: Make CodeSet a regular non-inherited object

Implemented helper function to correctly calculate a texture's size

svc: Fix typos in sanitizing checks for MapMemory/UnmapMemory

Fixed incorrect types for svcBreak

These only exist to ferry data into a Process instance and end up going
out of scope quite early. Because of this, we can just make it a plain
struct for holding things and just std::move it into the relevant
function. There's no need to make this inherit from the kernel's Object
type.

Passing an invalid nmap handle to Remap should throw an error

thread: Remove unnecessary memset from ResetThreadContext()

Added error codes for nvmap

Regular value initialization is adequate here for zeroing out data. It
also has the benefit of not invoking undefined behavior if a non-trivial
type is ever added to the struct for whatever reason.

HwOpus, Implemented DecodeInterleavedWithPerformance

svc: Add missing address range sanitizing checks to MapMemory/UnmapMemory

nvhost_as_gpu: Flush/invalidate CPU VAddr on UnmapBuffer.

gl_shader_decompiler: Implement VMAD

Added error for invalid nmap handles

Used by sonic ages

Fixed block height settings for RenderTargets and Depth Buffers

This adds the missing address range checking that the service functions
do before attempting to map or unmap memory. Given that both service
functions perform the same set of checks in the same order, we can wrap
these into a function and just call it from both functions, which
deduplicates a little bit of code.

Implemented Scissor Testing

gl_shader_decompiler: Implement geometry shaders

kernel/thread: Use a regular pointer for the owner/current process