bug fix

tools/nuget-download-package/main.go

@@ -179,67 +179,73 @@ func decidePackageVersionRange(packageName, frameworkVersion string, indexJsons
 func decidePackageVersion(frameworkVersion, packageVersion string, indexJsons, indexJsons_Login []string) (maxAvailableVersion, maxAvailableVersionUrl, maxAvailableVersionUrlLogin string) {
 	// The golang json parse library sucks. Prevent it from crashing
 	//   on a json syntax error.
+	//
+	// This function is very ugly. Fucking go-json library and go exception.
 	defer func() {recover()} ()
 
 	for indexJson_currIndex, indexJson := range indexJsons {
-		defer func() {recover()} () // try parse, skip this entry on error
-		// entry = xml.findall("/items/[]/items/[]/catalogEntry")
-		// entry/version, entry/dependencyGroups[]/targetFramework, entry/../packageContent
-		// If there's no `targetFramework` in dependencyGroups, this package depends on specific version of parent package. it sucks.
-		var j1 map[string]interface{}
-		json.Unmarshal([]byte(indexJson), &j1)
-		j2 := j1["items"].([]interface{})
-		for _, j2ele := range j2 {
-			defer func() {recover()} () // try parse, skip this entry on error
-			j3 := j2ele.(map[string]interface{})["items"]
-			j4 := j3.([]interface{})
-			for _, jPkgVersionItem_ := range j4 {
-				defer func() {recover()} () // try parse, skip this entry on error
-				jPkgVersionItem := jPkgVersionItem_.(map[string]interface{})
-				jCatalogEntry := jPkgVersionItem["catalogEntry"].(map[string]interface{})
-				myVersionText := jCatalogEntry["version"].(string)
-				// log.Println("DEBUG: reaching " + myVersionText)
-
-				// Let's check if this version is ok
-				thisPkgVersionIsOk := false
-
-				if frameworkVersion != "" {
-					if j5, ok := jCatalogEntry["dependencyGroups"]; ok {
-						for _, j6 := range j5.([]interface{}) {
-							j7 := j6.(map[string]interface{})
-							if j8, ok := j7["targetFramework"]; ok {
-								if frameworkVersion == netVersionNugetFormatToStandardFormat(j8.(string)) {
-									thisPkgVersionIsOk = true
-									break
+		func () {
+			defer func() { recover() }() // try parse, skip this entry on error
+			// entry = xml.findall("/items/[]/items/[]/catalogEntry")
+			// entry/version, entry/dependencyGroups[]/targetFramework, entry/../packageContent
+			// If there's no `targetFramework` in dependencyGroups, this package depends on specific version of parent package. it sucks.
+			var j1 map[string]interface{}
+			json.Unmarshal([]byte(indexJson), &j1)
+			j2 := j1["items"].([]interface{})
+			for _, j2ele := range j2 {
+				j3 := j2ele.(map[string]interface{})["items"]
+				j4 := j3.([]interface{})
+				for _, jPkgVersionItem_ := range j4 {
+					func() {
+						defer func() { recover() }() // try parse, skip this entry on error
+						jPkgVersionItem := jPkgVersionItem_.(map[string]interface{})
+						jCatalogEntry := jPkgVersionItem["catalogEntry"].(map[string]interface{})
+						myVersionText := jCatalogEntry["version"].(string)
+						// log.Println("DEBUG: reaching " + myVersionText)
+
+						// Let's check if this version is ok
+						thisPkgVersionIsOk := false
+
+						if frameworkVersion != "" {
+							if j5, ok := jCatalogEntry["dependencyGroups"]; ok {
+								for _, j6 := range j5.([]interface{}) {
+									j7 := j6.(map[string]interface{})
+									if j8, ok := j7["targetFramework"]; ok {
+										if frameworkVersion == netVersionNugetFormatToStandardFormat(j8.(string)) {
+											thisPkgVersionIsOk = true
+											break
+										}
+									} else {
+										// this pkgVersion has no targetFramework limitation.
+										thisPkgVersionIsOk = true
+									}
 								}
 							} else {
-								// this pkgVersion has no targetFramework limitation.
+								// no dependencyGroups at all
 								thisPkgVersionIsOk = true
 							}
 						}
-					} else {
-						// no dependencyGroups at all
-						thisPkgVersionIsOk = true
-					}
-				}
 
-				if packageVersion != "" {
-					thisPkgVersionIsOk = packageVersion == myVersionText
-				}
+						if packageVersion != "" {
+							thisPkgVersionIsOk = packageVersion == myVersionText
+						}
 
-				if thisPkgVersionIsOk {
-					// log.Println("DEBUG: good " + myVersionText)
-					// This version is ok! Log it.
-					myVersionUrl := jPkgVersionItem["packageContent"].(string)
-					if version.CompareSimple(myVersionText, maxAvailableVersion) == 1 {
-						// if left > right
-						maxAvailableVersion = myVersionText
-						maxAvailableVersionUrl = myVersionUrl
-						maxAvailableVersionUrlLogin = indexJsons_Login[indexJson_currIndex]
-					}
+						if thisPkgVersionIsOk {
+							// log.Println("DEBUG: good " + myVersionText)
+							// This version is ok! Log it.
+							myVersionUrl := jPkgVersionItem["packageContent"].(string)
+							if version.CompareSimple(myVersionText, maxAvailableVersion) == 1 {
+								// if left > right
+								maxAvailableVersion = myVersionText
+								maxAvailableVersionUrl = myVersionUrl
+								maxAvailableVersionUrlLogin = indexJsons_Login[indexJson_currIndex]
+							}
+						}
+						// log.Println("DEBUG: leaving " + myVersionText)
+					}() // catch exception and continue
 				}
 			}
-		}
+		}() // catch exception and continue
 	}
 
 	return