This would result in svcSetMemoryAttribute getting the wrong value for
its third parameter. This is currently fine, given the service function
is stubbed, however this will be unstubbed in a future change, so this
needs to change.

file_sys/directory: Amend path buffer size for directory entries

patch_manager: Add support for disabling patches

Port citra-emu/citra#4476: "web_service: move telemetry condition from TelemetrySession constructor to destructor"

service/fsp_srv: Correct returned value in GetGlobalAccessLogMode()

file_sys/save_data_factory: Update SaveDataSpaceId enum

Implemented Shader Unique Identifiers

kernel/process: Set ideal core from metadata

savedata_factory: Add CacheStorage and delete TemporaryStorage on boot

vm_manager: Make vma_map private

gl_shader_decompiler: TLDS/TLD4/TLD4S Reworked reflecting the source registers, bugs fixed and modularize.

Based off RE, the backing code only ever seems to use 0-2 as the range
of values 1 being a generic log enable, with 2 indicating logging should
go to the SD card. These are used as a set of flags internally.

Given we only care about receiving the log in general, we can just
always signify that we want logging in general.

Fixes an issue where Testcases couldn't be sent when Telemetry was disabled, because both things are tied closely together in the backend.

service/ldr: Amend layouts of NRO and NRR headers

Amends it with missing values deduced from RE (ProperSystem being from
SwitchBrew for naming)

(SdCardUser wasn't that difficult to discern given it's used alongside
SdCardSystem when creating the save data indexer, based off the usage of
the string "saveDataIxrDbSd" nearby).

hle/service, hle/sm: Minor cleanup

Backport review comment from citra-emu/citra#4418

loaders: Make GetFileType() a const qualified member function

gl_shader_decompiler: TLDS/TLD4/TLD4S Reworked reflecting the source registers, bugs fixed and modularize.

Original reason:
As Windows multi-byte character codec is unspecified while we always assume std::string uses UTF-8 in our code base, this can output gibberish when the string contains non-ASCII characters. ::OutputDebugStringW combined with Common::UTF8ToUTF16W is preferred here.

Mimics hardware behavior.

configuration/config: Use an intermediary variable for accessing players

system_archive: Implement open source NgWord2

Given memory should always be expected to be valid during normal
execution, this should be a debug assertion, rather than a check in
regular builds.

This was only ever public so that code could check whether or not a
handle was valid or not. Instead of exposing the object directly and
allowing external code to potentially mess with the map contents, we
just provide a member function that allows checking whether or not a
handle is valid.

This makes all member variables of the VMManager class private except
for the page table.

 kernel/svc: Correct behavior of svcResetSignal() 

gl_rasterizer: Implement a framebuffer cache

gl_shader_decompiler: Implement TEXS.F16

Combines the two into one, shortening the amount of code here.

Only one usage of the specified objects made use of the lack of
namespacing. Given the low usage, we can just remove these.

These auto-deduce the result based off its arguments, so there's no need
to do that work for the compiler, plus, the function return value itself
already indicates what we're returning.

Gets rid of the need to keep the variables separate from their actual
initialization spots.

 system_archive: Use a regular function pointer instead of std::function for the file-scope system archive array

service/ldr: Deduplicate instruction cache clearing code in LoadNro()

Perf: Call shrink_to_fit after page-table vector resizing to actually reduce vector capacity

Similarly, here we can avoid doing unnecessary work twice by retrieving
the file type only once and comparing it against relevant operands,
avoiding potential unnecessary object construction/destruction.

While GetFileType() is indeed a getter function, that doesn't mean it's
a trivial function, given some case require reading from the data or
constructing other objects in the background. Instead, only do necessary
work once.